Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542436 Thomas Spura <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Blocks| |177841(FE-NEEDSPONSOR) --- Comment #1 from Thomas Spura <[email protected]> 2009-11-29 19:55:08 EDT --- Just a few comments, because I am no sponsor anyway: - There is no documentation. You should at least add %doc ChangeLog The folder doc would also be interesting -> %doc ChangeLog doc - There is no license file in the tarball: see: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text - see https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define Anything else looks good at the first sight. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
