Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=541807 --- Comment #4 from Matthew Kent <[email protected]> 2009-12-04 01:06:31 EDT --- Thank you for the review. (In reply to comment #3) > Some notes: > > * Version specific dependency > - I don't think ">= 3.7.0" ">= 3.0.0" is needed (as all rpms shipped > on Fedora satisfies this dependency) > ref: > https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires > Apologies, should have caught this. > ! demo > - I tried demo program, then: > ------------------------------------------------------------------- > [tasa...@localhost ~]$ > /usr/lib/ruby/gems/1.8/gems/ParseTree-3.0.4/demo/printer.rb > /usr/lib/ruby/gems/1.8/gems/ParseTree-3.0.4/demo/printer.rb:20: uninitialized > constant ParseTree (NameError) > ------------------------------------------------------------------- > I don't know well the usefulness of this script, however > at least "require 'parse_tree'" is missing. Yeah certainly doesn't look finished or useful at the moment, I'll exclude it with a note. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
