Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226379 --- Comment #2 from Ondrej Vasik <[email protected]> 2009-12-07 14:25:16 EDT --- Few comments before actual review: 1) Please add comment to spec file (at least) about source of rexec-1.5.tar.gz 2) Please comment patches (purpose, bugzillas) either in spec file or in patch itself 3) Requires: pam could be unversioned - 0.58 is quite old (even in RHEL-4 is newer) BuildRequires: audit-libs-devel could be unversioned - 1.5 is quite old (in RHEL-4 is older, in RHEL-5 newer) 4) Buildroot style is not ok - although it is no longer required, it would be better to fix this. rest looks ok at first sight... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
