Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542027





--- Comment #2 from Gianluca Sforna <[email protected]>  2009-12-08 18:42:50 EDT 
---
spec looks good, for more legibility I'd add some blank lines before %prep,
%build and %install.

One important thing though. I checked the license in nusoap.php and the correct
one looks like LGPLv2+

http://nusoap.cvs.sourceforge.net/viewvc/nusoap/lib/nusoap.php?revision=1.121&view=markup

You may also consider dropping the requirement on PHP 4.2, I'm pretty sure
every current build target in Fedora has a newer one.

Only the license is a blocker, fix it and I can approve this package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to