Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547655 Ralf Corsepius <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Flag| |fedora-review? --- Comment #1 from Ralf Corsepius <[email protected]> 2009-12-16 00:10:39 EDT --- For obvious reasons, I am going to review this ;) * MUSTFIX: Your patch creates a backup files, which gets installed: # rpm -qlp perl-Module-Install-RTx-0.25-2.fc12.noarch.rpm /usr/lib/perl5/vendor_perl/5.10.0/Module /usr/lib/perl5/vendor_perl/5.10.0/Module/Install /usr/lib/perl5/vendor_perl/5.10.0/Module/Install/RTx /usr/lib/perl5/vendor_perl/5.10.0/Module/Install/RTx.pm /usr/lib/perl5/vendor_perl/5.10.0/Module/Install/RTx.pm.try_RTHOME_first /usr/lib/perl5/vendor_perl/5.10.0/Module/Install/RTx/Factory.pm /usr/share/doc/perl-Module-Install-RTx-0.25 /usr/share/doc/perl-Module-Install-RTx-0.25/Changes /usr/share/doc/perl-Module-Install-RTx-0.25/README /usr/share/man/man3/Module::Install::RTx.3pm.gz Note the file named RTx.pm.try_RTHOME_first. * Can you explain your patch? The original code first searches @INC, then searches the other (IMO questionable) places. As this module's purpose is to first check where RT is installed on a system, your patch IMO is wrong. Did you propose your patch to upstream? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
