Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544660 --- Comment #2 from Christof Damian <[email protected]> 2010-01-02 05:43:16 EDT --- (In reply to comment #1) > Quick notes before review : > - Requires php-cli is redundant with php-pear > - replace pear.swiftmailer.org.xml by %{name}.xml (cf PHP Guidelines) > > I think using REST version provided (here 1.3) as version could be a good idea > for this package where version have no really meaning. As with the other channels I got for review I just copied the one from php-channel-doctrine. Removing php-cli makes sense. I am not sure about the version number, the channel format is version 1.0 and all other php-channel-* seem to use that at the moment. It might be worth discussing that on the fedora-php list. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
