Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551878 Terje Røsten <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Terje Røsten <[email protected]> 2010-01-03 05:55:51 EDT --- Some comments: a) you can remove python from req, pygtk2 will pull that, drop commas too. b) spell out the file names in %files c) you have to handle the desktop file: https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files d) Drop INSTALL from %doc e) why is these needed: %attr(0755,root,root) and %attr(0644,root,root) in %files needed? f) never seen _datarootdir used before, why not _datadir? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
