Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=552999 Andrea Musuruane <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Andrea Musuruane <[email protected]> 2010-01-07 04:44:15 EDT --- I had a quick glance at the SPEC file and I found some problems: * "Requires: hicolor-icon-theme" is required because you install icons in %{_datadir}/icons/hicolor/* * For new packages, do not apply a vendor tag to desktop files: https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files * You mixed macro styles. You used both %{buildroot} and $RPM_BUILD_ROOT: https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS * You didn't use the name macro in Source0 but you used the version macro. Please be consistent and use both: https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
