Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services Alias: pear-Svcs-Weather https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200 ------- Additional Comments From [EMAIL PROTECTED] 2006-11-18 12:15 EST ------- Hi Remi, quick comment before I start the formal review. I looked over your spec file and I wonder why you choose to use # as your delimiter character in your sed command? # is used as a comment in a spec file and this looks very confusing to a reader of the spec file, please change # to @ instead. Also you use %{__sed} however you do not use macros for any other of your system commands, you should be consistent and just use "sed", I think it came up during the discussion of creating the template that macro usage for system commands was only needed in %post(pre)/%post(pre)un sections. Therefore, I would change the sed line to read: sed -i -e s@/usr/local/bin/[EMAIL PROTECTED]/php@ $RPM_BUILD_ROOT%{pear_datadir}/%{pear_name}/buildMetarDB.php -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
