Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: pkgconfig


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226299





------- Additional Comments From [EMAIL PROTECTED]  2007-02-02 01:49 EST -------
MUSTFIX:

- Invalid debuginfos.
Please remove the strip %{bindir}/* line

- Package ships an aclocal macro
=> Requires: automake

- %makeinstall
Package supports make DESTDIR and therefore should use it.

SHOULD:
- Package wastes time on building shared libs while it only uses the static one
=> Consider %configure ... --disable-shared


Remark:
pkgconfig shipping a local copy of glib and links statically against is
gradually showing its negative sides. The amount of warnings this code emits
proves this code to be showing its age and lets it appear as really 
error-prone. 
Should pkgconfig support linking against an external glib, this would be 
preferred.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to