Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: dos2unix https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225706 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag|fedora-review? |fedora-review- ------- Additional Comments From [EMAIL PROTECTED] 2007-02-03 12:35 EST ------- * RPM name is OK * Builds fine in mock * File list looks OK Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * No downloadable source. Please give the full URL in the Source tag. * Please use %{dist} in Release tag * Preserve file timestamps in %install Rpmlint is not silent: Source RPM: W: dos2unix invalid-license Freely distributable W: dos2unix no-url-tag W: dos2unix macro-in-%changelog description rpmlint of dos2unix: W: dos2unix invalid-license Freely distributable (you can use GPL) W: dos2unix no-url-tag -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
