Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: gnome-audio https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225812 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] CC| |[EMAIL PROTECTED] Flag|fedora-review? |fedora-review- ------- Additional Comments From [EMAIL PROTECTED] 2007-02-04 12:43 EST ------- Good: * Source URL is canonical * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * All paths begin with macros * All directories are owned by this or other packages * Builds fine in mock. Must fix: * rpmlint error: W: gnome-audio hardcoded-path-in-buildroot-tag /var/tmp/gnome-audio-%{version}-root Buildroot must be '%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)'. Minor things to look at, not blockers: * Might be nice to move the %files section before the ChangeLog. * rpmlint error: W: gnome-audio summary-ended-with-dot Sounds for GNOME events. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
