Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libexif https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226003 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] CC| |[EMAIL PROTECTED] Flag|fedora-review? |fedora-review- ------- Additional Comments From [EMAIL PROTECTED] 2007-02-04 14:30 EST ------- First issues and suggestions, in random order: * Several patch files in CVS are not used. Please remove. * change BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * The resolved URL for Source0 (http://umn.dl.sourceforge.net/sourceforge/libexif/lixexif-0.6.13.tar.bz2) gives me a 404 HTTP error. * The AUTHORS files shipped in the RPM is empty. * Change the Requires line of -devel to %{name} = %{version}-%{release} * Devel package description says that there are also static packages. There are not. * Don't use %makeinstall. Use make DESTDIR=$RPM_BUILD_ROOT install. * Documents are installed into two different directories, /usr/share/doc/libexif (in libexif-devel) and /usr/share/doc/libexif-%{version} (in libexif). Make them one. * Make -devel require pkgconfig, as it includes *.pc files. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
