Bug 226411: Merge Review: setserial Product: Fedora Extras Version: devel Component: Package Review
manuel wolfshant <[EMAIL PROTECTED]> has denied Tim Waugh <[EMAIL PROTECTED]>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411 ------- Additional Comments from manuel wolfshant <[EMAIL PROTECTED]> Review for Release: 19.2.2 MUSTFIX: there are a couple of problems with the spec and the patches * the fhs patch has two errors +mandir = @bindir@ <-- this should be @mandir@ + $(STRIP) $(DESTDIR)$(bindir)/setserial -< should not be at all, leads to empty debuginfo * the readme patch should include references to Fedora, not Red Hat * the spec does not include the preferred BUILDROOT, does not honor SMP flags,uses %makeinstall instead of make install Warning from rpmlint: Summary ends with dot I will attach the fixes for all of the above. Please use whatever you find useful and once corrected I will do the formal full review. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
