Bug 226357: Merge Review: rdate Product: Fedora Extras Version: devel Component: Package Review
Roozbeh Pournader <[EMAIL PROTECTED]> has denied Roozbeh Pournader <[EMAIL PROTECTED]>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226357 ------- Additional Comments from Roozbeh Pournader <[EMAIL PROTECTED]> Random first notes: * Remove the dot at the end of Summary line. * It seems that there is no upstream. No URL is given, and the Source address doesn't work either. So I can't check that this is the same as the upstream source. (BLOCKER) * Change BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * Use the option %{?_smp_mflags} for make. * Don't use %makeinstall, if possible. See http://fedoraproject.org/wiki/Packaging/Guidelines#MakeInstall * Use %defattr(-,root,root,-) instead of %defattr(-,root,root) * Consider using %{?dist} in Release tag. * The binary file 'rdate' is installed with permission 555 in the Makefile. It should be 755. This can be fixed either by patching the Makefile or by explicitly changing the permission in the %install or %files section. (BLOCKER) _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
