Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: autofs - A tool for automatically mounting and unmounting filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227631 ------- Additional Comments From [EMAIL PROTECTED] 2007-02-09 03:19 EST ------- (In reply to comment #8) > 1. I generally contest the assertion that replacing file deps with package > deps > is "good". > > They are not equivalent. It ignores the fact that applications can be moved > between packages at any time, and that tools can change their location (even > within a package) at any time. > > 2. rpm scriptlets introduce a direct dependency of a package on a file and > will > fail or produce invalid results when these files move/are removed/replaced. > > 3. rpm scriptlets are special wrt. execution order upon package > removal/upgrade/installation (for details c.f. > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets) > > This introduces special constraints on package dependencies, which become > utterly complicated when tools change their location rsp. move between > packages. > > > Admitted, /sbin/chkconfig, /sbin/service and /bin/bash are unlikely to be > moved/removed in near future, but for the sake of clarity of specs and to > avoid > problems related to 1-3. above, I am enforcing a rule of > "To be safe, each tool being explicitly and unconditionally invoked in > scriptlets, must be explicitly listed as file dep in Requires(xxx)" > > I am not sure if there is a corresponding rule in the guideline, but I think > so. Yes. Changed back. That's what I had originally. I made it that way prior to the review because it seemed the safest way and made the spec file usage consistent, but not quite the level of thinking as above. This doesn't appear to be covered in the guidelines above but reading them there is an implicit use of full paths in scriplets and Requires which implies the points above. Ian -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
