Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: javassist-3.1-1jpp - Java Programming Assistant: 
bytecode manipulation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227067


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[EMAIL PROTECTED]




------- Additional Comments From [EMAIL PROTECTED]  2007-02-12 12:14 EST -------
Review Comments

* incorrect buildroot
 - should be:
   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

* changelog should be in one of these formats: (without epoch)

  * Fri Jun 23 2006 Jesse Keating <[EMAIL PROTECTED]> - 0.6-4
  - And fix the link syntax.

  * Fri Jun 23 2006 Jesse Keating <[EMAIL PROTECTED]> 0.6-4
  - And fix the link syntax.

  * Fri Jun 23 2006 Jesse Keating <[EMAIL PROTECTED]>
  - 0.6-4
  - And fix the link syntax.

* Summary tag should not end in a period

* use macros appropriately and consistently
 - ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to