Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nxml-mode - Emacs package for editing XML https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223023 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | Flag| |fedora-review+ ------- Additional Comments From [EMAIL PROTECTED] 2007-02-13 16:13 EST ------- Ok, I think that's good enough, approved. Final non-blocker suggestions to consider before doing the first build: - Drop trailing ".1" from the Version tag. - Instead of defining magic-mode-alist to a dummy value in nxml-init.el on earlier Emacsen (which may have side effects if other modes test for its existence and make decisions based on that), do something like this instead: (if (boundp 'magic-mode-alist) ;; then do the setq (which could be replaced by add-to-list, BTW...) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
