Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kio_p7zip - Kio-slave for viewing 7zip files using p7zip https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238499 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] CC| |[EMAIL PROTECTED] Flag| |fedora-review? ------- Additional Comments From [EMAIL PROTECTED] 2007-04-30 17:47 EST ------- Just a couple of really minor issues with this package: rpmlint says: W: kio_p7zip wrong-file-end-of-line-encoding /usr/share/doc/kio_p7zip-0.3.1/ChangeLog W: kio_p7zip wrong-file-end-of-line-encoding /usr/share/doc/kio_p7zip-0.3.1/README E: kio_p7zip zero-length /usr/share/doc/kio_p7zip-0.3.1/NEWS Basically, you don't need to package the empty NEWS file. Also, you'll want to use iconv to fix those file encodings: (add this to %install) # Fix file encoding recode() { iconv -f "$2" -t utf-8 < "$1" > "${1}_" mv -f "${1}_" "$1" } recode ChangeLog iso-8859-1 recode README iso-8859-1 Last but not least, I assume the .la files are really needed for KDE? I'm not a KDE user, but if they can be avoided, that would be ideal. Adding Rex to the CC for this, as he'll know. Fix those minor items, show me a new spec/SRPM, and I'll do the rest of the review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
