Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lcdtest - utility to display monitor test patterns https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241099 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From [EMAIL PROTECTED] 2007-06-06 04:02 EST ------- (In reply to comment #10) > FYI, the link you supplied for review requests waiting for a reviewer does not > work for me; it returns a message "The search named mtasaka-review-noone does > not exist." Still does not work for you? Maybe the link can be used only by me? > Possibly this URL might be suitable instead: > https://bugzilla.redhat.com/bugzilla/showdependencytree.cgi?id=163776 FE-NEW bugtracker is no longer used (we are still wanting for the other methods which can replace FE-NEW bugtracker, and mtasaka-review-noone mark works for me...) Well, * This package is okay * From a quick glance, the other reviews you requested seem almost okay ! NOTE: - For asl: ------------------------------------------------ make install %{_smp_mflags} DESTDIR=$RPM_BUILD_ROOT ------------------------------------------------ for make install, while I have not checked asl, there are many packages where parallel make for "make install" causes race condition problem (for example, the timing of "making directory" and "putting files in the directory") - For drawtiming: ------------------------------------------------- ./configure CFLAGS="$RPM_OPT_FLAGS" \ --bindir=%{_bindir} \ --libdir=%{_libdir} \ --mandir=%{_mandir} -------------------------------------------------- - Perhaps the above can be replaced with just %configure? (please check what %configure does by `rpm --eval %configure`) Okay. ------------------------------------------------- This package (lcdtest) is APPROVED by me ------------------------------------------------- Please follow the procedure written on http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account" When you requested someone to sponsor you (in the procedure above), please make a note on this bug that you did so. If you want to push this package also on F-7, you also have to check: http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT after the URL above. !! Well, recenctly Fedora package system changed a lot !! If you have some questions, please let me know. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
