Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gengetopt - Tool to write command line option parsing code for C programs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243607 ------- Additional Comments From [EMAIL PROTECTED] 2007-06-10 15:30 EST ------- Other points: * Working directory on %build, %install stage - is actually $RPM_BUILD_DIR/%{name}-%{version}. So please use simply . (dot) . * macros - Please check the defined macros on http://fedoraproject.org/wiki/Packaging/RPMMacros . /usr/share is already defined as %_datadir * Header files location - Usually header files should be located under %_includedir, not under %_datadir. * parallel make - parallel make failed by -j2. So please disable parallel make with leaving comments * Timestamps - This package installs some files without any modification on rebuild and keeping timestamps on those files is recommended. For this package, it can be done by: ----------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p" ----------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
