Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: oyranos - The Oyranos Colour Management System (CMS) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239936 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2007-06-15 13:49 EST ------- Some random notes: * Please make the compile log more verbose * Add 'INSTALL="%{__install} -p" to make install * What rpm own %{syscolordir}? (Please check directories' ownership) * While %syscolordir is used, %{_datadir}/color/ is also used in spec file * Is the definition %usercolordir needed (for this spec file)? (and there seems to be other unused macros) * %configure already uses --libdir=%_libdir * For make install: -------------------------------------------------------- make DESTDIR=$RPM_BUILD_ROOT install install_gui -------------------------------------------------------- This will be sufficient. * Would you tell me what %post script actually does? (especially, does %post script change some files?) (In reply to comment #1) > Some updates (remaining rpaths) * Would you tell me what rpath issues remain? (mock build log may be useful) * For %clean: why do you have to remove __doc directory explicitly? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
