Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: curl https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225671 ------- Additional Comments From [EMAIL PROTECTED] 2007-06-22 07:02 EST ------- None of the remaining patches touch autotools input files, so running aclocal etc. is no longer needed. The "make install" command can be simplified down to this: make DESTDIR=%{buildroot} INSTALL="%{__install} -p" install That might also get rid of the rpmlint warning from the SRPM about mixed use of spaces and tabs. The configure option for the CA bundle needs to be specified without reference to %{buildroot}, because the packaged /usr/bin/curl-config has a reference to the buildroot in it as things stand. Please standardize on either %{buildroot} or $RPM_BUILD_ROOT; either is fine but don't mix both in the same spec. The packaged libcurl.pc has a Libs.private: that references -L/usr/lib64 (in the 64-bit version); I'm not sure if that's a problem but I prefer to get rid of refences to standard library directories by adding a quick sed after running the configure script: # Remove -L options for standard library directories sed -i -e 's,-L/usr/lib ,,g;s,-L/usr/lib64 ,,g;s,-L/usr/lib$,,g;s,-L/usr/lib64$,,g' \ Makefile libcurl.pc Perhaps docs/CONTRIBUTE could be added to the devel package? P.S. It's "Paul Howarth", not "Paul Horwath"... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
