Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Slony-1 (postgresql-slony-engine) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199154 ------- Additional Comments From [EMAIL PROTECTED] 2007-07-09 15:36 EST ------- Hello, > See configure file for this. You mean the PACKAGE_NAME? The tarball is slony1-1.2.10.tar.bz2, the upstream project is called Slony-I, and the first line of the README file says Slony-I. From the NamingGuidelines: When naming a package, the name should match the upstream tarball or project name from which this software came. > Missing yacc parser.y parser.c >> ? No idea what this means. yacc is provided by bison, and seems to be used by Slony-I: http://www.gnu.org/software/bison/ > - Since postgresql_autodoc is now available, maybe you can add it to the > BuildRequires >> I don't think so. Is there anything that depends on autodoc? configure is searching for it, so I assume it is used. > Some people may skip doc builds. But doc is a separate package in Fedora, and people can just choose to not install it. > Slony looks for /usr/local/pgsql/bin/pg_config first. If someone has a source > installation of PostgreSQL, then the build will break This won't be a problem when the package is build on the Fedora buildservers. I understand that you want to maintain one upstream specfile for all versions of Red Hat and Fedora, but having a clean spec in Fedora makes things more easier in the long run. A few other comments: - Double BuildRequires for docbook-style-dsssl - Is %kerbdir still needed? If not, there's no need to change CFLAGS, CXXFLAGS and CFLAGS and a simple %configure will do. And: rpmlint of postgresql-slony1-engine-docs: E: postgresql-slony1-engine-docs non-standard-dir-perm /usr/share/doc/postgresql-slony1-engine-docs-1.2.10/support 0644 E: postgresql-slony1-engine-docs non-standard-dir-perm /usr/share/doc/postgresql-slony1-engine-docs-1.2.10/adminguide 0644 E: postgresql-slony1-engine-docs non-standard-dir-perm /usr/share/doc/postgresql-slony1-engine-docs-1.2.10 0644 E: postgresql-slony1-engine-docs non-standard-dir-perm /usr/share/doc/postgresql-slony1-engine-docs-1.2.10/concept 0644 E: postgresql-slony1-engine-docs non-standard-dir-perm /usr/share/doc/postgresql-slony1-engine-docs-1.2.10/howto 0644 E: postgresql-slony1-engine-docs non-standard-dir-perm /usr/share/doc/postgresql-slony1-engine-docs- 1.2.10/implementation 0644 Cheers, Ruben -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
