Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wdaemon - hotplug helper for wacom x.org driver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249059 ------- Additional Comments From [EMAIL PROTECTED] 2007-07-24 12:18 EST ------- > * rpmlint output acceptable (post full output w/waiver notes where needed): > $ rpmlint /build/RPMS/x86_64/wdaemon-*0.10-2* > W: wdaemon non-conffile-in-etc /etc/udev/rules.d/61-uinput-wacom.rules > W: wdaemon non-conffile-in-etc /etc/udev/rules.d/61-uinput-stddev.rules > > I'm thinking it wouldn't hurt to just mark these %config(noreplace), in the > event a user does go and edit them/append to them. It completely silences > rpmlint if we go that route, and I don't see any real reason not to just do > it. fixed > * If ExcludeArch used, must be documented why (and a bug filed against ExArch > tracker once approved): NEEDS WORK ok, removed excludearch/exclusivearch: the package will compile and work on all architectures. It may be not useful if the machine doesn't has USB ports to use a tablet. > * Permissions on %files sane: PASS -- though I might suggest some further > updates to the Makefile to use 'install -mXXXX' to install the binaries and > init > script, rather than having to use %attr in the %files section. fixed. All the fixes included as patches are queued for next upstream release http://people.redhat.com/arozansk/wdaemon/ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
