Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: gnome-speech https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225836 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2007-07-27 09:18 EST ------- I was passing by and I noticed some problems. I don't have the time for a formal review though. Maybe later. The following line at the beginning of the spec file is not needed: %define po_package gnome-speech It should be deleted. %makeinstall macro should not be used, if possible: http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28package%29%7C%28review%29#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 If it is not possible you should put a remark to avoid reports from people like me :) gnome-speech-espeak subpackage should require espeak. I think you should also make a separate subpackage for festival like you did with espeak. It should be possible to use espeak without having festival installed. Therefore the Requires tag for festival should be moved from the main package. Are you sure gettext is required? I cannot see no translation neither in the original source package nor in the spec file. HTH. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
