Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: vcmd - A developers interface to the Linux-VServer kernel interface https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250468 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review- ------- Additional Comments From [EMAIL PROTECTED] 2007-08-12 10:10 EST ------- MD5Sum: ef7787845e698017b370923b919ab023 vcmd-0.09.tar.bz2 Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All directories are owned by this or other packages * All necessary BuildRequires listed. * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners * Package builds fine in Mock. Bad: * Not all paths use macros. In particular, look at '/usr/sbin/'. refer to http://fedoraproject.org/wiki/Packaging/RPMMacros * rpmlint produces the following errors: W: vcmd no-documentation This error can be ignored, since the tarball contains no documentation. W: vcmd invalid-license GPL This error needs to fixed though. I looked through the tarball, and couldn't find any mention of the license used. Also, if it is actually GPL, we will need to clarify what version according to the new license tag guidelines. refer to http://fedoraproject.org/wiki/Licensing Note: Looks like a newer version of this package is available. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
