Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-olpcgames - Utilities for writing games on the OLPC platform https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250533 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From [EMAIL PROTECTED] 2007-08-12 10:27 EST ------- MD5Sum: ecadb8e31684dc2e4994f06078a40999 olpcgames-20070801git4ab726.tar.bz2 Good: * Source URL is canonical * git tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All directories are owned by this or other packages * All necessary BuildRequires listed. * Files have appropriate permissions and owners * Package builds fine in Mock. * rpmlint produces no error. Minor: * You can remove sitearch variable, since this is a no arch package. * The CFLAGS call in the build section is unnecessary. * You should drop the %{python_sitearch} from the file section, since this is a noarch package +1 APPROVE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
