Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Linux-Complete-Backup-and-Recovery-HOWTO - bare metal recovery scripts & docs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250747 ------- Additional Comments From [EMAIL PROTECTED] 2007-08-14 14:58 EST ------- Thank you, Mr. Boyle. > ? - Package meets naming and packaging guidelines > --> Seems more a set of scripts than documentation... although I could be > looking at what it does all wrong :P Consider renaming after script-suite? Hmmm. The current name is the name of the document at the Linux Documentation Project, and I figured that consistency would be a good idea. The main package is some of the scripts (more are to come), and the -doc subpackage is the original HOWTO in various formats. I could make the docs the main package and put the scripts into a -scripts subpackage, I suppose, but the current naming and subpackaging are consistent with current Fedora usage. I'm open to suggestions here. > OK? - Spec has consistant macro usage. > --> $RPM_BUILD_ROOT could be macro-ified as %{buildroot} OK, done. It should show up in the next version. > NOT OK - Sources SHOULD match upstream md5sum > --> Source: e44ce87defb0b7f3688dbbded79bedc4 Package: > e44ce87defb0b7f3688dbbded79bedc4 I'm not sure where that came from. In any case, it should go away as soon as I put new packages up on my server. > ? - Changelog section is correct. > --> Not sure if one should put such direct references to the specfile in > %changelog... but it's probably bad form to change the %changelog after the > fact... That was the reason for the new package version, and the sole change. As with this one. Again, new SRPM: http://www.charlescurley.com/Linux-Complete-Backup-and-Recovery-HOWTO/srpms/Linux-Complete-Backup-and-Recovery-HOWTO-2.3-3.fc7.src.rpm And the revised spec is at the usual: http://www.charlescurley.com/Linux-Complete-Backup-and-Recovery-HOWTO/Linux-Complete-Backup-and-Recovery-HOWTO.spec BTW, since my web page is pretty much automated, and comments for this bugzilla entry are not, the web page (http://www.charlescurley.com/Linux-Complete-Backup-and-Recovery-HOWTO.html) is authoritative for the most recent version, not bugzilla. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
