Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot https://bugzilla.redhat.com/show_bug.cgi?id=243501 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From [EMAIL PROTECTED] 2007-09-08 10:43 EST ------- License should be GFDL according to http://fedoraproject.org/wiki/Licensing#head-19fc3ef10add085a28cb06784dc34ef8b05a9bd6-2 and index.html You use tabs and spaces in the spec, e.g. in Group you align with spaces but in URL you align with tabs. Please use either tabs or spaces. I did not try it but I guess you can simplify the spec when you use in %prep %setup -q -n manual-en dos2unix qtiplot.adp and in %files %doc * Then you can remove mkdir -p $RPM_BUILD_ROOT/%{_docdir}/%{name} tar -xjf %{SOURCE0} -C $RPM_BUILD_ROOT/%{_docdir}/%{name} dos2unix $RPM_BUILD_ROOT/%{_docdir}/%{name}/manual-en/qtiplot.adp from %install. In %files a %defattr(-,root,root,-) before the %doc is missing. According to http://soft.proindependent.com/manuals.html the documentation is version 0.8.9 Imho you should skip the %{?dist} tag in Release and ask rel-eng everytime you built a package to sync it to all Fedora releases, this will also avoid updating the manual everytime one updrades the system. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
