Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libconfig - simple library for manipulating structured configuration files https://bugzilla.redhat.com/show_bug.cgi?id=264641 ------- Additional Comments From [EMAIL PROTECTED] 2007-09-13 05:03 EST ------- For 1.1.3-1: * rpmlint - First please check your rpms by rpmlint before submitting to review request. ----------------------------------------------------- libconfig.i386: E: info-files-without-install-info-postin /usr/share/info/libconfig.info.gz libconfig.i386: E: info-files-without-install-info-postun /usr/share/info/libconfig.info.gz libconfig.i386: E: library-without-ldconfig-postin /usr/lib/libconfig.so.2.2.3 libconfig.i386: E: library-without-ldconfig-postun /usr/lib/libconfig.so.2.2.3 libconfig.i386: W: file-not-utf8 /usr/share/doc/libconfig-1.1.3/AUTHORS libconfig.i386: E: library-without-ldconfig-postin /usr/lib/libconfig++.so.2.2.3 libconfig.i386: E: library-without-ldconfig-postun /usr/lib/libconfig++.so.2.2.3 libconfig-devel.i386: W: no-documentation ----------------------------------------------------- For this package, the rpmlint complaint above must all be fixed (for this package, info file should be moved to -devel subpackage). * Static archive - Please remove static archives and pass "--disable-static" option to %configure. * Documents - File "INSTALL" is for people who want to build this package by themselves and not needed for people who use rpm for installing this package. (also check the section "Documentation" of http://fedoraproject.org/wiki/Packaging/Guidelines) - And please also check if "README" file is needed. - File "ChangeLog" contains the useful info for developers and should be added to -devel subpackage. * pkgconfig .pc file - A package which contains pkgconfig .pc file must have "Requires: pkgconfig". Check: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines * Timestamp - I recommend ----------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ----------------------------------------------------------- to keep timestamp on the installed header files and info file. This method usually work for packages using recent Makefile. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
