Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: babl - A dynamic, any to any, pixel format conversion library https://bugzilla.redhat.com/show_bug.cgi?id=328771 ------- Additional Comments From [EMAIL PROTECTED] 2007-10-12 10:54 EST ------- (In reply to comment #4) > > Also the timestamps are still not kept. As above, I propose: > > make DESTDIR=%{buildroot} install INSTALL='install -p' > > > I don't see why its necessary, the packaging guildeline say to do it, when the > copy command is used. There's no mention of doing it for make install. It is an obvious deficiency of the guidelines. It is obviously better to keep timestamps for all the files that are not generated (and sometimes it is also better to have relevant timestamps on generated files, in case of multiarch packages sharing those files). > > The changelog entry is not very clear in my opinion: > > - Remove the use of inexistent source (from package reviews) > A typo, should have been 'inexistent source url'. Will fix. Ok. > > As for shipping babl svn snapshot in F-7 I think that it > > should be avoided, unless there are severe regression/bugs or > > there are wonderful new functionalities. > Actually, there are 'wonderful new functionalities' in latest gnome-scan (at > least according to the author), and it depends the svn version of babl and > gegl. Ok. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
