Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices https://bugzilla.redhat.com/show_bug.cgi?id=343871 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From [EMAIL PROTECTED] 2007-10-20 12:40 EST ------- - License tag should be GPLv2+, the source files contain "version 2 or any later" - missing BuildRequires: proj-devel libusb-devel (+desktop-file-utils) - as it is a GUI application a desktop file must be provided - the parallel make command should be "make %{?_smp_mflags}" - QLANDKARTE_LIBDIR (defined in QLandkarte/common) is used for plugins and they must be installed in %{_libdir}/..., so hardcoding /usr/lib/ works only for 32-bit architectures - QMAKE_CXXFLAGS_RELEASE (defined in QLandkarte/common) set to -O3 overrides Fedora's default level (-O2) - in the %files section the %{_libdir}/%{name} directory is not owned, you can use it as it includes the *.so too -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
