Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-share - Easy sharing folder via Samba (CIFS) protocol https://bugzilla.redhat.com/show_bug.cgi?id=354441 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2007-11-22 10:05 EST ------- If you are talking about koji scratch build, I guess you cannot do because you are not sponsored. Anyway: * Please remove redundant BuildRequires. - For example, gtk2-devel requires glib2-devel, so "BuildRequires: glib2-devel is not needed". There are some other redundant BuildRequires (eel2-devel has many dependencies) - And is libglade-devel (not libglade2-devel) really needed for BuildRequires? * For perl module dependency, please write the module name, not direct rpm name like "Requires: perl(XML::Parser)" c.f. http://fedoraproject.org/wiki/Packaging/Perl * Try to add 'INSTALL="install -p"' to 'make install' to keep timestamps on installed files. This method "usually" works for recent makefiles. * The file "INSTALL" is usually unneeded. This file is generally needed for people who want to compile/install a package by themselves and not needed for rpm users. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
