Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libnxml - simple C library for parsing, writing and creating XML https://bugzilla.redhat.com/show_bug.cgi?id=374791 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2007-12-03 08:23 EST ------- Your newest spec/srpm is what is written on your comment 0, is it okay? (from next time please change the release number every time you modify your spec file to avoid confusion). By the way, you can check general packaing guidelines from http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines As far as I just glanced at your (perhaps newest) spec file: * Buildroot tag you are using now is not valid for Fedora * Remove static archive. I prefer to delete these files at %install section like ------------------------------------------------------ %install (some install process) %{__rm} -f $RPM_BUILD_ROOT%{_libdir}/lib*.{a,la} ------------------------------------------------------ ? Maybe %configure accepts --disable-static option to avoid static archive creation * We now recommend %defattr(-,root,root,-) * By the way, the newest libnxml is already 0.9? * I am just watching your spec file, however your spec file contains ------------------------------------------------------ %doc test/*.c ------------------------------------------------------ Does this mean that you can execute some check program after building libnxml? If so, please create %check section and do some test program in %check. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
