Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: man-pages-it https://bugzilla.redhat.com/show_bug.cgi?id=226125 ------- Additional Comments From [EMAIL PROTECTED] 2007-12-06 08:18 EST ------- (In reply to comment #7) > Please ignore the previous comment, unless you are interested in man-pages-ko > as > well. :-P If time permits I'll be glad to :) > man-pages-it is ready now, would you mind to have a look? OK. Here we go on again. New issues: 15. You should not use dos2unix. Use sed instead: http://fedoraproject.org/wiki/Packaging/Guidelines#head-41d4336fa1af8d74500eb89d3a22410cccc4117d 16. I missed this in the main review. There is no need to specify the builddir path. You can (and really should) write the lines like the following: mv %{_builddir}/%{name}-%{version}/description %{_builddir}/%{name}-%{version}/DESCRIPTION-IT mv %{_builddir}/%{name}-%{version}/%{extra_pkg_name}/changelog %{_builddir}/%{name}-%{version}/EXTRA-CHANGELOG in this way: mv description DESCRIPTION-IT mv %{extra_pkg_name}/changelog %{extra_pkg_name}/EXTRA-CHANGELOG I suggest you to leave extra package docs in %{extra_pkg_name} and then use %doc {extra_pkg_name}/EXTRA-CHANGELOG but this is not mandatory at all. Issues still to be solved: 4, 13, 14. Write the following lines Source0: ftp://ftp.pluto.it/pub/pluto/ildp/man/man-pages-it-%{version}.tar.gz Source1: ftp://ftp.pluto.it/pub/pluto/ildp/man/man-pages-it-extra-%{extra_ver}.tar.gz in this way: %define extra_name %{name}-extra %define extra_ver 0.5.0 %define extra_pkg_name %{extra_name}-%{extra_ver} Source0: ftp://ftp.pluto.it/pub/pluto/ildp/man/%{name}-%{version}.tar.bz2 Source1: ftp://ftp.pluto.it/pub/pluto/ildp/man/%{extra_pkg_name}.tar.gz like you did for man-pages-es. 10. rpmlint returns: man-pages-it-extra.noarch: E: description-line-too-long ufficiale, e che di solito vengono distribuite assieme ai software. Cerchiamo di man-pages-it-extra.noarch: E: description-line-too-long indietro rispetto all'ultima versione del pacchetto di riferimento. E' possibile 5, 6, 12. All these issues were not addressed. Please do also update the other man packages you own where applicable and notify the changes to the relevant bugs when done. Thanks. Bye, Andrea. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
