Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xorg-x11-drv-diamondtouch - Xorg diamondtouch input driver https://bugzilla.redhat.com/show_bug.cgi?id=251536 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From [EMAIL PROTECTED] 2008-02-14 23:05 EST ------- I of course don't have the hardware to test this, but I can check the package otherwise. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (MIT) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 198d2c738c16537c273546f2e74538bd xf86-input-diamondtouch-0.2.0.tar.bz2 198d2c738c16537c273546f2e74538bd xf86-input-diamondtouch-0.2.0.tar.bz2.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install See below - Headers/static libs in -devel subpackage. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. Might ask upstream to include a copy of the license they use. Not a blocker of course. 2. rpmlint complains: xorg-x11-drv-diamondtouch.x86_64: W: devel-file-in-non-devel-package /usr/include/diamondtouch/ee_defs.h Is there any point in shipping this header file? I'll leave it up to you if you want to ship that header or not, otherwise this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
