Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fox - A C++ library for GUI development https://bugzilla.redhat.com/show_bug.cgi?id=431665 ------- Additional Comments From [EMAIL PROTECTED] 2008-03-08 03:46 EST ------- (In reply to comment #10) > (In reply to comment #6) > > The files in %_bindir also share a common namespace, so in > > there too they should be fox-PathFinder and fox-calculator. > > (and corresponding man pages). > > > > Upstream has advised me NOT to change it. What are their arguments? The bindir is shared between all applications, the names of commands should be specific. > fox-config can be dropped in fedora since it is mainly for other distro's. If other upstream programs use fox-config it should be in fedora. > > Regarding the include files there are very strange things, namely > > there are autoconf conditionals in headers, like in fx3d.h > > #ifdef HAVE_GLU_H > > > > This is not right, these conditionals should be in .cpp files, > > not in the API. > > The condition could probably be removed, if the classes not dependent > on OpenGL are moved back to fx.h [FXVec** and so on]. These could > be useful in a 2D environment w/o GL. Whatever solution is used, the conditionals should go. An API should never be conditional. But indeed part of the api could be factored out in files not installed if that part of the api isn't compiled in the library. > > The file xincs.h is especially full of these, and also full of > > include files for other APIs. However it doesn't seems to be included > > in any other file, so it may certainly be dropped completely from > > the fox API. > > > > This file is needed to write custom API's advised by upstream. How can they advise that? Do they advise relying on autoconf conditionals? It is plain wrong. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
