Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: rubygem-rubyforge - A script which automates a limited set of rubyforge operations https://bugzilla.redhat.com/show_bug.cgi?id=443250 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From [EMAIL PROTECTED] 2008-04-29 17:04 EST ------- Review on -2: Good: - rpmlint checks return: rubygem-rubyforge.src: W: mixed-use-of-spaces-and-tabs (spaces: line 41, tab: line 7) rubygem-rubyforge.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/rubyforge-0.4.4/lib/rubyforge.rb 0644 - package meets naming guidelines - package meets packaging guidelines (generic and Ruby) - license (GPLv2+ or Ruby) OK, text not in package, matches source - spec file legible, in am. english - source matches upstream (a955f92ebbb47953c3333c7f8428d3f168506cc4) - package builds on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Please fix the non-executable-script error in a new SRPM/SPEC and I will approve. You may also want to advise upstream to properly license their code, only one file seems to mention the license, and the text of the license is not included in the Gem. This is not a blocker for Fedora inclusion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
