Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: embryo - Easy to use library for running compiled PAWN programs https://bugzilla.redhat.com/show_bug.cgi?id=442266 ------- Additional Comments From [EMAIL PROTECTED] 2008-05-06 03:23 EST ------- (In reply to comment #6) > Embryo is for scripting existing applications, similar to LUA, and embryo > scripts are usually distributed as source code. It's not the case of C > compiler, such scripts are compiled and ran by regular users. > LUA ships compiler in one package with libs. Indeed, but in the case of embryo, it seems to be much more common to use directly the libs. And e17 packages depending on embryo only use the libs, so it seems to me that putting the interpreter in its own pacage (with name embryo) would be better, in order not to install the interpretr if not needed. Moreover the interpreter (in contrast with the one embedded in the libs) seems to be less well maintained (reading the README). Also, unless I am missing something the %description is mostly for the -libs package, the interpreter has still not been that much modified. Now regarding the segfault, in my opinion it is much better to do a patch (and submit it upstream). A sed substitution will silently fail and in general is less readable. In the end it depends on the packager, but in my opinion the change in argv should be a patch, while the 2 other sed substitutions are right. As a side note, this segfault is also an indication that the interpretor is not widely used. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
