Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: decibel-audio-player - Music player for GNOME


https://bugzilla.redhat.com/show_bug.cgi?id=431335


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |163779
              nThis|                            |
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From [EMAIL PROTECTED]  2008-05-20 23:08 EST -------
Good point regarding python files. They are arch independent so leave them in
%{_datadir}

I'll leave it to you to decide Music or Audio player, Music is fine. Both work
fine in English. The key word users will see is Decibel anyways.

Nice citation of the guidelines, that BuildRoot does meet the requirements.


So:

+ Still builds in development
+ Works
+ rpmlint is clean
+ Includes byte compiled files
+ License matches, GPLv2+
+ Proper Requires and BuildRequires
+ Installed .desktop file, appears under "Sound and Video"
+ Proper use of macros


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to