Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xorg-x11-drv-suncg6 - X driver for suncg6 https://bugzilla.redhat.com/show_bug.cgi?id=448561 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From [EMAIL PROTECTED] 2008-06-03 21:44 EST ------- MD5Sum: aa6b7836fe6ccc99994bf15ff2b74e86 xf86-video-suncg6-1.1.0.tar.bz2 Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners Bad: * rpmlint produces the following errors which should be fixed: xorg-x11-drv-suncg6.sparc64: E: standard-dir-owned-by-package /usr/share/man/man4 xorg-x11-drv-suncg6.sparc64: E: standard-dir-owned-by-package /usr/share/man xorg-x11-drv-suncg6.sparc64: W: invalid-license MIT/X11 Looking at the license matrix, it looks like it should just be MIT. You can fix this when you import this into CVS. And the directory errors can also be fixed at import time. Note: I don't have the hardware to verify that this driver works, but from a packaging standpoint this package looks fine. +1 APPROVE. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
