Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-keyring-sharp - Mono implementation of GNOME Keyring https://bugzilla.redhat.com/show_bug.cgi?id=454229 ------- Additional Comments From [EMAIL PROTECTED] 2008-07-08 08:54 EST ------- BAD source files match upstream: - MD5 matches but tarball name is gnome-keyring-sharp.tar.gz?view=tar not gnome-keyring-sharp.tar.gz BAD package meets naming and versioning guidelines. - Appears to contain an extra 1 appended to the dist tag OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (MIT). License text included in package. N/A latest version is being packaged. OK BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in koji (Rawhide/x86_64). BAD debuginfo package looks complete. - Debuginfo package is empty, debug package need to be disabled OK rpmlint is silent. - only contains the standard bogus warnings for Mono packages OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths, correct scriptlets exist OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK pkgconfig files are in devel subpackage N/A no libtool .la droppings. OK not a GUI app. Also I apologize for forgetting to do this review yesterday, I got drowned by bugzilla spam. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
