Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: odfpy - Python library for manipulating OpenDocument files https://bugzilla.redhat.com/show_bug.cgi?id=455210 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From [EMAIL PROTECTED] 2008-07-14 22:26 EST ------- Build cleanly in mock. * rpmlint clean * sources match upstream: a8e76163f9d328fe7b8b93617cdc945692758408 odfpy-0.7.tgz * package meets naming guidelines x doesn't use consistent macros: I'd go with %{optflags} and %{buildroot} instead of $RPM_OPT_FLAGS and $RPM_BUILD_ROOT * build root is ok * correct/allowed license tag x License text is added to the package - http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text says it shouldn't be. I'd take it out for now and bug upstream :-) * Requires/BuildRequires are OK * No %check section, but the tests don't seem completely functional at the moment (bug upstream) * Installs/uninstalls fine * Permissions are fine APPROVED (just fix those the above tiny issues) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
