Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dbus-c++ - Native C++ bindings for D-Bus https://bugzilla.redhat.com/show_bug.cgi?id=455575 ------- Additional Comments From [EMAIL PROTECTED] 2008-07-16 09:38 EST ------- formal review: OK source files match upstream OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (LGPLv2+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. BAD compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). BAD debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths, correct scriptlets exists OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel subpackage. OK pkgconfig files in devel subpackage. OK no libtool .la droppings. OK not a GUI app. - wrong flags are passed to the compiler, looks like package's own - can't see any source files in the debuginfo package (depends on the flags issue) - and I would use the git-archive to generate the source archive, but that's not any blocker, it would decrease the size from 750 KB to only 50 KB ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
