Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460387


Parag AN(पराग) <[EMAIL PROTECTED]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[EMAIL PROTECTED]
         AssignedTo|[EMAIL PROTECTED]    |[EMAIL PROTECTED]




--- Comment #1 from Parag AN(पराग) <[EMAIL PROTECTED]>  2008-08-28 08:14:32 EDT 
---
Suggestions:-
1)Where is upstream? I don't see URL tag in spec file. Add URL.
2) your build and install section for python package should look like this
%build
%{__python} setup.py build

%install
rm -rf $RPM_BUILD_ROOT
%{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT

See 
http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_using_Setuptools

4) preserve timestamps while using cp and install commands with -p option

5) conditional if is not needed F9>= releases
%if "%{python_ver}" >= "2.5"
%{python_sitearch}/*.egg-info
%endif
 remove it and add only egginfo file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to