Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=459880 Mamoru Tasaka <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] --- Comment #6 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-09-03 08:39:27 EDT --- ! Some comments - This file is noarch, almost no actual builds are made during rpmbuild, so keeping timestamps on installed files are highly recommended. So I prefer to * Use "cp -a" (or "cp -pr") instead of "cp -r". * and use 'make install DESTDIR=$RPM_BUILD_ROOT install="install -p"' (This is not blockers) * %doc - %{_defaultdocdir}/ is marked as %doc by default so the prefix %doc is redundant. * Source tarball - which I could download from the URL does not coincide with the one in your srpm. ! %changelog - I recommend to add hyphen before each change description like: ----------------------------------------------------------- * Sun Aug 24 2008 Mikhail Fedotov <anyremote at mail.ru> - 0.5.2-2 - Corrected files permissions and specs ------------------------------------------------------------ (see: http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs ) (This is not a blocker) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
