Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454220 Mamoru Tasaka <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] --- Comment #25 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-09-07 13:40:40 EDT --- Hi; Some random comments: - Please consider to use %{?dist} tag: https://fedoraproject.org/wiki/Packaging/DistTag - The URL written as Source0 seems 404 - "BuildRequires: pycairo-devel" is redundant because pygtk2-devel Requires pycairo-devel - Support parallel make if possible, otherwise write as a comment that parallel make is intentionally disabled: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make - Desktop files must be handled by desktop-file-install: https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files - During build GConf schemas installation must be disabled. Also some proper scriptlets and Requires should be added - see: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf Note: We does not regard gconf schemas files as config file, so please remove %config(noreplace) attribution from gconf file, even if rpmlint warns for it. - XML file is installed under %{_datadir}/mime/packages, so please refer to https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo - Please make it sure that all directories created when installing this package are correctly owned by this package - ref: https://fedoraproject.org/wiki/PackagingDrafts/UnownedDirectories -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
