Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452211 --- Comment #6 from Jochen Roth <[EMAIL PROTECTED]> 2008-09-10 11:36:37 EDT --- (In reply to comment #4) > Following the reviewer guide verbatim I find the following issues > • BuildRequires should include gcc Isn't gcc part of the standard packages? > • ${RPM_BUILD_ROOT} used instead of %{buildroot} > I also proffer the opinion that > • ExclusiveArch may be a little restrictive, it /should/ work on x86_64 Ok, I'll remove the ExclusiveArch statement. > I believe that BuildRequires must include gcc and I suspect that the > ${RPM_BUILD_ROOT} and ExclusiveArch issues are because of the style employed > by > the packager, something I'm unqualified to critique. Quoting the CreatePackageHowTo http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo "You may have $RPM_BUILD_ROOT instead of %{buildroot}; just be consistent." -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
