Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461821 Tom "spot" Callaway <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] --- Comment #2 from Tom "spot" Callaway <[EMAIL PROTECTED]> 2008-09-10 17:35:33 EDT --- REVIEW (based on updated spec) ======= Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (CC-BY-SA) OK, text in %doc, matches source - spec file legible, in am. english - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - macro use consistent - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - content, OK - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Should Fix: - Source tarball has no upstream URL location. You should really make a home for it and reference the full URL in the spec. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
